Update ProtoBuf to 1.x and regenerate protobuf definitions#151
Open
KristianHolme wants to merge 1 commit into
Open
Update ProtoBuf to 1.x and regenerate protobuf definitions#151KristianHolme wants to merge 1 commit into
KristianHolme wants to merge 1 commit into
Conversation
Regenerate src/protojl with ProtoBuf.jl 1.3 to use the current decode API and remove the deprecated-codegen warning, bumping Julia compat to 1.10 accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the ProtoBuf.jl deprecation warning:
src/protojl/with ProtoBuf.jl 1.3 (newdecode(d, T, _endpos, _group)API)ProtoBuf1.0.11→1, Julia1.6→1.10(required by ProtoBuf 1.3)tensorboard_plugin_text, etc.) after regenerationhparams.jlfor newHParamInfo.differsfieldDictencode/decode workarounds (ProtoBuf 1.3 handles maps natively)writeproto/ legacyhaspropertycodecompile_proto.jlnow replaces existing output and renames plugin modules;download_proto_sourcefixes Linuxsedforstruct.proto→struct_tb.protoTest plan
Pkg.test()— 166 passed, 1 failed (optional Plots PNG bytes), 1 broken (Graph Logger; pre-existing)Made with Cursor